Skip to content

Add experimental huh-only prompter gated by GH_EXPERIMENTAL_PROMPTER #12859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
williammartin merged 14 commits into from
Mar 26, 2026
+1,468 −56
Merged

Add experimental huh-only prompter gated by GH_EXPERIMENTAL_PROMPTER #12859

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
87426ee
Add experimental huh-only prompter gated by GH_EXPERIMENTAL_PROMPTER
BagToad Mar 7, 2026
726714d
Use LayoutStack for huhPrompter MultiSelectWithSearch
BagToad Mar 7, 2026
4661c05
Fix gofmt alignment for prompter-enabled fields in IOStreams
BagToad Mar 7, 2026
f294831
Upgrade to huh/v2 and fix selection persistence in MultiSelectWithSearch
BagToad Mar 19, 2026
86d876f
test(huh prompter): add table-driven tests for all prompt types
BagToad Mar 19, 2026
4d74e05
refactor(huh prompter): pipe-based test harness with full coverage
BagToad Mar 19, 2026
95a59f4
fix(accessible prompter): update test expectations for huh v2
BagToad Mar 19, 2026
38e10d5
fix(huh prompter): use synchronized accessors to eliminate data race
BagToad Mar 19, 2026
f38abbe
feat(huh prompter): add placeholder to search input
BagToad Mar 19, 2026
cfb2224
refactor(huh prompter): custom Field for MultiSelectWithSearch
BagToad Mar 19, 2026
13e47d0
feat(huh prompter): clear search input after submitting query
BagToad Mar 19, 2026
f92fab6
go mod tidy
BagToad Mar 19, 2026
84a3ba8
fix(huh prompter): remove unused fields and imports
BagToad Mar 20, 2026
cb2b505
Ensure huh prompter cleans up
williammartin Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(huh prompter): remove unused fields and imports 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
  • Loading branch information
@BagToad @williammartin
2 people authored and williammartin committed Mar 26, 2026
commit 84a3ba83e469e758280873d1c0c892bfc816487a
16 changes: 5 additions & 11 deletions internal/prompter/multi_select_with_search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@ import (
"fmt"
"io"
"strings"
"time"

"charm.land/bubbles/v2/key"
"charm.land/bubbles/v2/spinner"
"charm.land/bubbles/v2/textinput"
"charm.land/bubbles/v2/viewport"
tea "charm.land/bubbletea/v2"
"charm.land/huh/v2"
"charm.land/lipgloss/v2"
Expand All @@ -23,17 +21,14 @@ type multiSelectSearchField struct {
// configuration
title string
searchTitle string
placeholder string
searchFunc func(string) MultiSelectSearchResult

// state
mode msMode // which sub-component has focus
search textinput.Model
cursor int
viewport viewport.Model
loading bool
loadingStart time.Time
spinner spinner.Model
mode msMode // which sub-component has focus
search textinput.Model
cursor int
loading bool
spinner spinner.Model

// options and selections
options []msOption
Expand Down Expand Up @@ -111,7 +106,6 @@ func newMultiSelectSearchField(
// deliver the result via msSearchResultMsg.
func (m *multiSelectSearchField) startSearch(query string) tea.Cmd {
m.loading = true
m.loadingStart = time.Now()
searchFunc := m.searchFunc
return tea.Batch(
func() tea.Msg {
Expand Down