fix(secret/set): strip trailing CR from env-file secrets on Windows#13673
Open
jfjrh2014 wants to merge 1 commit into
Open
fix(secret/set): strip trailing CR from env-file secrets on Windows#13673jfjrh2014 wants to merge 1 commit into
jfjrh2014 wants to merge 1 commit into
Conversation
CRLF line endings cause a trailing carriage return to be included in secret values parsed from --env-file on Windows. The stdin path already strips this with bytes.TrimRight on body, but the env-file path skips it. Fixes cli#13588
|
Thanks for your pull request! While it doesn't meet all of our standard requirements, it appears to be a small, focused contribution and has been routed to the team for review. Note: We still encourage linking to an issue with the |
github-actions
Bot
added
external
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRLF line endings cause a trailing carriage return to be included in secret values parsed from --env-file on Windows. The stdin path already strips this with bytes.TrimRight in getBody, but the env-file path skips it.
This applies bytes.TrimRight to each secret value after godotenv.Parse, matching the existing pattern.
Fixes #13588