PoC: snapshot#1889
Draft
acamargo wants to merge 18 commits into
Draft
Conversation
ericdallo
reviewed
Oct 21, 2024
ericdallo
reviewed
Oct 21, 2024
ericdallo
reviewed
Oct 21, 2024
ericdallo
reviewed
Oct 21, 2024
ericdallo
reviewed
Oct 21, 2024
|
|
||
| result)) | ||
|
|
||
| (defn discard |
Member
There was a problem hiding this comment.
I consider as a must have measure the time we take on this function.
Using criterium is probably the fastest way: https://clojure-lsp.io/development/#debugging-profiling
ericdallo
reviewed
Oct 21, 2024
ericdallo
left a comment
ericdallo
left a comment
Member
There was a problem hiding this comment.
I wonder what extension should we save the file, txt, edn, transit, I'd like to understand the performance for txt in a real world scenario (a project with considerably large diagnostics and some snapshots)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This is a proof-of-concept and the code needs improvements and optimizations in order to reach a production level standard.
Why
When working with a legacy codebase with numerous linter issues, prioritizing code sanitization can be overwhelming. This PR introduces a "snapshot" feature to alleviate this burden by allowing you to "pause" diagnostics for existing code, focusing on addressing new issues that arise.
What
The snapshot feature freezes the diagnostics currently present in your codebase, preventing Clojure-LSP from highlighting them. This allows you to concentrate on making incremental improvements without being overwhelmed by past linter violations.
How
To create a snapshot, simply run the following command:
clojure-lsp diagnostics --raw > .lsp/snapshot.txtOnce the snapshot is created, Clojure-LSP will automatically ignore any diagnostics listed in the
.lsp/snapshot.txtfile during subsequent analysis, providing a more focused development experience.docsfolder)