This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Improve migration guide#509
Merged
Merged
Conversation
emlaver
approved these changes
Dec 17, 2021
emlaver
left a comment
emlaver
left a comment
Contributor
There was a problem hiding this comment.
Looks good! A couple of comments
| 1. Replay adapters are replaced by the [automatic retries](https://github. | ||
| com/IBM/ibm-cloud-sdk-common/#automatic-retries) feature for failed requests. | ||
| 1. Error handling is not transferable from `python-cloudant` to `cloudant-python-sdk`. For more information go to the [Error handling section](https://cloud.ibm.com/apidocs/cloudant?code=python#error-handling) in our API docs. | ||
| 1. Configuring HTTP client is not transferable from `python-cloudant` to `python-java-sdk`. For more information go to the [Configuring the HTTP client section(https://githubcom/IBM/ibm-cloud-sdk-common/#configuring-the-http-client) in the IBM Cloud SDK Common README. |
Contributor
There was a problem hiding this comment.
Maybe we should say something like:
Suggested change
| 1. Configuring HTTP client is not transferable from `python-cloudant` to `python-java-sdk`. For more information go to the [Configuring the HTTP client section(https://githubcom/IBM/ibm-cloud-sdk-common/#configuring-the-http-client) in the IBM Cloud SDK Common README. | |
| 1. Custom HTTP client configurations in `python-cloudant` are not transferable to `python-java-sdk`. For more information go to the [Configuring the HTTP client section(https://githubcom/IBM/ibm-cloud-sdk-common/#configuring-the-http-client) in the IBM Cloud SDK Common README. |
| |`Document(db, '_local/docid').fetch()`|[`getLocalDocument`](https://cloud.ibm.com/apidocs/cloudant?code=python#getlocaldocument)| | ||
| |`Document(db, '_local/docid').save()`|[`putLocalDocument`](https://cloud.ibm.com/apidocs/cloudant?code=python#putlocaldocument)| | ||
| |`Document(db, '_local/docid').delete()`|[`deleteLocalDocument`](https://cloud.ibm.com/apidocs/cloudant?code=python#deletelocaldocument)| | ||
| |`db.missing_revisions()/db.revisions_diff`|[`postRevsDiff`](https://cloud.ibm.com/apidocs/cloudant?code=python#postrevsdiff)| |
Contributor
There was a problem hiding this comment.
Suggested change
| |`db.missing_revisions()/db.revisions_diff`|[`postRevsDiff`](https://cloud.ibm.com/apidocs/cloudant?code=python#postrevsdiff)| | |
| |`db.missing_revisions()/db.revisions_diff()`|[`postRevsDiff`](https://cloud.ibm.com/apidocs/cloudant?code=python#postrevsdiff)| |
eiri
approved these changes
Dec 20, 2021
vmatyus
reviewed
Jan 3, 2022
| 1. Replay adapters are replaced by the [automatic retries](https://github. | ||
| com/IBM/ibm-cloud-sdk-common/#automatic-retries) feature for failed requests. | ||
| 1. Error handling is not transferable from `python-cloudant` to `cloudant-python-sdk`. For more information go to the [Error handling section](https://cloud.ibm.com/apidocs/cloudant?code=python#error-handling) in our API docs. | ||
| 1. Custom HTTP client configurations in `python-cloudant` are not transferable to `python-java-sdk`. For more information go to the [Configuring the HTTP client section(https://githubcom/IBM/ibm-cloud-sdk-common/#configuring-the-http-client) in the IBM Cloud SDK Common README. |
There was a problem hiding this comment.
What is python-java-sdk? Shouldn't it be cloudant-python-sdk?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.md|CHANGELOG.md) or test/build only changesDescription
My goal was to improve the migration guide dispersing the fog around the support of the retry feature an error handling.
Approach
postChangeshas changedpostPartitionFindhas changedpostMissingRevsis excluded from the SDKs, I replaced it withpostRevsDiffSchema & API Changes
Security and Privacy
Testing
Monitoring and Logging