fix: bound metric exporter state growth#42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
MetricExporter retained every counter label set it had ever observed and persisted the complete metrics/counter snapshot under one Durable Object storage value. Label churn could therefore cause unbounded memory/storage growth and eventually oversized writes.
A failed alarm could also exhaust Cloudflare's finite platform retries before the application scheduled its next alarm. The Worker would remain available but continue serving stale metrics indefinitely. The top-level alarm recovery path now schedules a fallback alarm one minute later after any unexpected failure. If fallback scheduling itself fails, the error is rethrown so platform retries still apply.
GraphQL products unavailable to an account were also treated as successful empty responses and queried every minute.
Testing
bun install --frozen-lockfilebun run checkbun run typecheckbun run test(34 tests)wrangler deploy --dry-runwith a temporary valid KV namespace IDCloses #28