[wrangler] fix: handle deleted entry point during hot-reload without unhandled rejection#13838
Conversation
🦋 Changeset detectedLatest commit: 801090b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
workers-devprod
requested review from
a team and
penalosa
and removed request for
a team
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
@NuroDev @penalosa @dario-piotrowicz — all Copilot review comments have been addressed. This PR is ready for review. |
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
@cloudflare/wrangler-bundler
commit: |
matingathani
force-pushed
the
fix/unhandled-rejection-esbuild-entry-deleted
branch
from
bfd2ac8 to
9df1c4a
Compare
|
The Windows CI failure is unrelated to this PR's changes. What failed: What this PR touches: only This looks like a known flaky Windows browser/CDP test (browser session not starting in time on slow Windows runners). Could a maintainer re-run the failed jobs? 🙏 |
|
CI failure (Tests, Windows, packages-and-tools) is the same pre-existing miniflare browser plugin flake — browser session times out on the Windows runner. Unrelated to the hot-reload entrypoint fix. Could a maintainer re-run the failed job? |
|
This is approved and CI is green — could a maintainer merge when convenient? Thanks! |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
matingathani
force-pushed
the
fix/unhandled-rejection-esbuild-entry-deleted
branch
from
33f0eca to
801090b
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
This is approved by @penalosa with clean CI — could a maintainer merge when ready? |
Fixes #13122.
During
wrangler dev, if the worker entry point is deleted or moved between builds, thereadFileSynccall inside theupdateBundlecallback throws synchronously and is promoted to an unhandled promise rejection, crashing the process.Fix: Wrap the
readFileSynccall in a try/catch. On failure, log a warning and return the previous bundle unchanged, so the dev session stays alive.