Skip to content

[wrangler] Fix email sending commands to use correct API endpoints#14240

Merged
petebacondarwin merged 3 commits into
cloudflare:mainfrom
ttoino:joaop/EMAIL-1854
Jun 12, 2026
Merged

[wrangler] Fix email sending commands to use correct API endpoints#14240
petebacondarwin merged 3 commits into
cloudflare:mainfrom
ttoino:joaop/EMAIL-1854

Conversation

@ttoino

@ttoino ttoino commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

EMAIL-1854

Wrangler's email sending commands targeted API endpoints that do not exist (e.g. /zones/{id}/email/sending/enable, /zones/{id}/email/sending/disable, /zones/{id}/email/sending, and /zones/{id}/email/sending/dns), so they failed against the real API.

Email Sending is managed through sending subdomains, so these commands now use the correct endpoints:

  • email sending enable <domain> creates a sending subdomain (POST /zones/{id}/email/sending/subdomains)
  • email sending disable <domain> deletes the sending subdomain (DELETE /zones/{id}/email/sending/subdomains/{tag})
  • email sending settings <domain> reads a single sending subdomain (GET /zones/{id}/email/sending/subdomains/{tag})
  • email sending dns get <domain> always reads the subdomain's DNS records (GET /zones/{id}/email/sending/subdomains/{tag}/dns)
  • email sending list now lists sending subdomains: all subdomains across the account by default, or a single zone's subdomains when a domain or --zone-id is given

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: these email sending commands are in open beta and the user-facing command surface (arguments and output) is described via --help; this change corrects the underlying API endpoints so the existing commands work.

Open in Devin Review

@ttoino ttoino requested a review from workers-devprod as a code owner June 9, 2026 16:28
@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1765ba0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
@cloudflare/wrangler-bundler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod requested review from a team and petebacondarwin and removed request for a team June 9, 2026 16:28
@workers-devprod

workers-devprod commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

Comment thread .changeset/fix-email-sending-endpoints.md Outdated
Comment thread packages/wrangler/src/__tests__/email-routing.test.ts Outdated
Comment thread .changeset/fix-email-sending-endpoints.md Outdated
Comment thread packages/wrangler/src/email-routing/client.ts Outdated
@ttoino ttoino requested a review from petebacondarwin June 11, 2026 15:57

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread packages/wrangler/src/email-routing/client.ts
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jun 11, 2026
@github-project-automation github-project-automation Bot moved this from Untriaged to In Review in workers-sdk Jun 11, 2026

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from In Review to Approved in workers-sdk Jun 11, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jun 11, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14240

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14240

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14240

miniflare

npm i https://pkg.pr.new/miniflare@14240

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14240

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14240

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14240

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14240

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14240

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14240

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14240

wrangler

npm i https://pkg.pr.new/wrangler@14240

commit: 1765ba0

@petebacondarwin petebacondarwin merged commit 1fb7ba5 into cloudflare:main Jun 12, 2026
60 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants