Suggest Cloudflare skills installation after commands instead of before#14264
Merged
Conversation
🦋 Changeset detectedLatest commit: c78b74f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Contributor
|
✅ All changesets look good |
This comment was marked as resolved.
This comment was marked as resolved.
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
cb90570 to
9663ed3
Compare
9663ed3 to
dbe7564
Compare
dbe7564 to
bc545c5
Compare
5 tasks
This was referenced Jun 11, 2026
Closed
MattieTK
requested changes
Jun 12, 2026
Co-authored-by: Matt ‘TK’ Taylor <matttaylor@cloudflare.com>
MattieTK
approved these changes
Jun 12, 2026
workers-devprod
approved these changes
Jun 12, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14116
Before wrangler on every command would trigger the skills installation flow when it checks for agents configurations and after an interactive prompt potentially installs them for the user (at most once).
This had many various edge cases and downsides, like:
Now instead the question is presented after the successful execution of non-long lived commands (such as
wrangler login), this doesn't insert the prompt upfront for every command so it should address all the problematic edge case scenarios we've seen.Additionally this PR adds extra logic to save the skills metadata file before asking the prompt (and potentially overriding it after), this should ensure that user should not see this prompt more than once.
Example of new flow:
To try the flow just run one of the Wrangler commands that trigger this using the prerelease, like for example:
(To trigger this make sure not to have a
agents-skills-install.jsoncfile in your global.wranglerdirectory)A picture of a cute animal (not mandatory, but encouraged)