Skip to content

Graduate autoconfig from experimental to stable#14276

Merged
dario-piotrowicz merged 1 commit into
mainfrom
dario/graduate-autoconfig
Jun 12, 2026
Merged

Graduate autoconfig from experimental to stable#14276
dario-piotrowicz merged 1 commit into
mainfrom
dario/graduate-autoconfig

Conversation

@dario-piotrowicz

Copy link
Copy Markdown
Member

Autoconfig has been turned on by default for a long time now and it was supposed to be stabilized much sooner, in any case I am graduating it in this PR since I don't think that the feature needs to still be experimental.

Note: The programmatic API is still experimental though, I think this will be useful as it will allow us to extract those function in their own package without neither being a breaking change for wrangler or forcing wrangler to re-export them.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: the docs already treat autoconfig as stable

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8217a04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Minor
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ask-bonk

ask-bonk Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

That's just a leftover inconsistency (one test still passes --autoconfig explicitly while others were simplified to default), but since --autoconfig is now the default and a valid flag, it's harmless and not actionable.

My review is complete. The change is a clean, well-tested flag rename/graduation. The only substantive consideration is backward compatibility for the removed experimental flags, but:

  • The flags carried experimental prefixes (x-/experimental-), so no stability guarantee applied
  • The changeset documents the replacement clearly
  • A minor version bump is appropriate

This is intentional and acceptable. There are no logic bugs, security issues, or incorrect API behaviors. The tests are updated consistently, the metrics allow-list key is correctly renamed, and the open-next delegation correctly forwards verbatim args.

LGTM

github run

@github-actions

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@pkg-pr-new

pkg-pr-new Bot commented Jun 12, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14276

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14276

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14276

miniflare

npm i https://pkg.pr.new/miniflare@14276

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14276

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14276

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14276

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14276

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14276

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14276

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14276

wrangler

npm i https://pkg.pr.new/wrangler@14276

commit: 8217a04

@dario-piotrowicz dario-piotrowicz added ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials and removed ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials labels Jun 12, 2026
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review June 12, 2026 10:46
@workers-devprod workers-devprod requested review from a team and NuroDev and removed request for a team June 12, 2026 10:47
@workers-devprod

workers-devprod commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread packages/wrangler/src/deploy/index.ts

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 12, 2026
@dario-piotrowicz dario-piotrowicz merged commit 32f9307 into main Jun 12, 2026
124 of 157 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/graduate-autoconfig branch June 12, 2026 14:37
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants