Implement support for YAML and JSON codecs for the file lookup#537
Conversation
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=========================================
+ Coverage 87.54% 87.65% +0.1%
=========================================
Files 94 94
Lines 6072 6158 +86
=========================================
+ Hits 5316 5398 +82
- Misses 756 760 +4
Continue to review full report at Codecov.
|
phobologic
left a comment
phobologic
left a comment
There was a problem hiding this comment.
Needs docs - otherwise this looks good to me.
| return Base64(result.data) if b64 else result | ||
|
|
||
|
|
||
| def _parameterize_obj(obj): |
There was a problem hiding this comment.
Can we get some docstrings in here?
danielkza
force-pushed
the
lookup-file-yaml-json
branch
from
e4f08c3 to
403a6a4
Compare
|
Rebased and added docstrings to most of the functions. @phobologic |
phobologic
left a comment
phobologic
left a comment
There was a problem hiding this comment.
Thanks for picking this back up! Awesome.
|
Ahh, issues with a long line from lint. Tried to fix it, but couldn't push to your branch @danielkza - simple fix, can you clean that up and then I'll merge? Thanks! |
danielkza
force-pushed
the
lookup-file-yaml-json
branch
from
403a6a4 to
52b38ef
Compare
|
Rebased and hopefully fixed the warning :) |
|
Looks great, thanks @danielkza |
…dtools#537) * Implement support for YAML and JSON codecs for the file lookup * Document YAML and JSON codecs for the file lookup * lookups: file: fix linter warning in test
3 participants
No description provided.