Fixes issue with non-interactive changeset updates & stack policies#657
Merged
Merged
Conversation
create change set doesn't allow a `stack_policy` argument like create/update stack calls. This was handled in the interactive version, but not in the non-interactive version. Fixes #650
russellballestrini
approved these changes
Sep 6, 2018
| 'UPDATE', service_role=self.service_role, **kwargs | ||
| ) | ||
|
|
||
| self.deal_with_changeset_stack_policy(fqn, stack_policy) |
Member
There was a problem hiding this comment.
Ok cool, so this is the bug, you refactored the logic so you could call it here.
ejholmes
approved these changes
Sep 6, 2018
ejholmes
left a comment
ejholmes
left a comment
Contributor
There was a problem hiding this comment.
This was handled in the interactive version,
but not in the non-interactive version.
I didn't even realize we hit changesets in non-interactive. In what scenario is that possible? When a stack is protected?
Member
Author
Contributor
|
@ejholmes ChangeSets are required when a Transform is present, both on create & on update. |
phrohdoh
pushed a commit
to phrohdoh/stacker
that referenced
this pull request
Dec 18, 2018
…loudtools#657) create change set doesn't allow a `stack_policy` argument like create/update stack calls. This was handled in the interactive version, but not in the non-interactive version. Fixes cloudtools#650
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create change set doesn't allow a
stack_policyargument likecreate/update stack calls. This was handled in the interactive version,
but not in the non-interactive version.
Fixes #650