Skip to content

Locked stacks still have requirements#746

Merged
phobologic merged 1 commit into
cloudtools:masterfrom
mromaszewicz:locked_dependencies
Nov 20, 2019
Merged

Locked stacks still have requirements#746
phobologic merged 1 commit into
cloudtools:masterfrom
mromaszewicz:locked_dependencies

Conversation

@mromaszewicz

@mromaszewicz mromaszewicz commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

This fixes #745 . Locked stacks still have dependencies, since there
is no difference between a locked stack and an unlocked stack at
creation time.

This fixes 745. Locked stacks still have dependencies, since there
is no difference between a locked stack and an unlocked stack at
creation time.
@mromaszewicz

Copy link
Copy Markdown
Contributor Author

Hmm, the lint check failed because the CircleCI system has the wrong version of boto. How can I fix this?

@troyready troyready self-requested a review November 14, 2019 18:44

@phobologic phobologic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@phobologic phobologic merged commit 7fc9648 into cloudtools:master Nov 20, 2019
@phobologic

Copy link
Copy Markdown
Member

I'll dig into the boto errors outside of this PR, thanks @mromaszewicz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Locked stacks do not properly construct dependency list.

3 participants