Skip to content

ci: add lint check to prevent single quotes in bootstrap scripts #22664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kacpersaw merged 2 commits into from
Mar 6, 2026
Merged

ci: add lint check to prevent single quotes in bootstrap scripts #22664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ccb22c
ci: add lint check to prevent single quotes in bootstrap scripts
kacpersaw Mar 5, 2026
a465360
Merge branch 'main' into kacpersaw/fix-bootstrap-single-quote-lint
Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ endif
# GitHub Actions linters are run in a separate CI job (lint-actions) that only
# triggers when workflow files change, so we skip them here when CI=true.
LINT_ACTIONS_TARGETS := $(if $(CI),,lint/actions/actionlint)
lint: lint/shellcheck lint/go lint/ts lint/examples lint/helm lint/site-icons lint/markdown lint/check-scopes lint/migrations $(LINT_ACTIONS_TARGETS)
lint: lint/shellcheck lint/go lint/ts lint/examples lint/helm lint/site-icons lint/markdown lint/check-scopes lint/migrations lint/bootstrap $(LINT_ACTIONS_TARGETS)
.PHONY: lint

lint/site-icons:
Expand Down Expand Up @@ -636,6 +636,11 @@ lint/shellcheck: $(SHELL_SRC_FILES)
shellcheck --external-sources $(SHELL_SRC_FILES)
.PHONY: lint/shellcheck

lint/bootstrap:
bash scripts/check_bootstrap_quotes.sh
.PHONY: lint/bootstrap


lint/helm:
cd helm/
make lint
Expand Down
24 changes: 24 additions & 0 deletions scripts/check_bootstrap_quotes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#!/usr/bin/env bash
set -euo pipefail
# shellcheck source=scripts/lib.sh
source "$(dirname "${BASH_SOURCE[0]}")/lib.sh"
cdroot

echo "--- check bootstrap scripts for single quotes"

files=$(find provisionersdk/scripts -type f -name '*.sh')
found=0
for f in $files; do
if grep -n "'" "$f"; then
echo "ERROR: $f contains single quotes (apostrophes)."
echo " Bootstrap scripts are inlined via sh -c '...' in templates."
echo " Single quotes break this quoting. Use alternative phrasing."
found=1
fi
done

if [ "$found" -ne 0 ]; then
exit 1
fi

echo "OK: no single quotes found in bootstrap scripts."
Loading