Skip to content

fix(scripts/check_emdash.sh): skip emdash check when no diff base is available #26491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f0ssel merged 1 commit into from
Jun 17, 2026
+10 −2
Merged

fix(scripts/check_emdash.sh): skip emdash check when no diff base is available #26491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions scripts/check_emdash.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,16 @@ else
fi

if [[ -z "$base" ]]; then
echo "WARNING: no base ref found, scanning all tracked files."
scan_all_files
# No base ref is available outside of pull requests, for
# example push builds on release branches with a shallow
# clone where neither GITHUB_BASE_REF nor origin/main is
# present. The diff check has nothing to compare against,
# and scanning every tracked file would flag pre-existing
# characters that are unrelated to the change under test.
# Skip instead; pass --all to force a full-tree scan.
echo "OK: no base ref found (not a pull request); skipping emdash check."
echo " Pass --all to scan every tracked file."
exit 0
else
# Ensure the base ref is fetchable. CI shallow clones
# (fetch-depth: 1) may not have the base branch available.
Expand Down
Loading