Sort the transfer accounts by favorite before sorting them alphabetically#622
Conversation
| public void bindView(View view, Context context, Cursor cursor) { | ||
| super.bindView(view, context, cursor); | ||
|
|
||
| Integer is_favorite = cursor.getInt(cursor.getColumnIndex(DatabaseSchema.AccountEntry.COLUMN_FAVORITE)); |
There was a problem hiding this comment.
Please, try to follow Java coding conventions. Variables should use camel case. For example, isFavorite instead of is_favorite.
| @@ -0,0 +1,24 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
Please, try to fix the editor warnings if possible. For example, in this line it says the <LinearLayout> and its contents can be replaced by a single <TextView> with a drawableEnd attribute.
|
Thanks for the pull request! I think it's a good idea. I've checked all the uses of There's one thing I don't like, though. I agree that the favorite stars help to avoid confusion about why those entries appear first when showing the list. However, when a favorite account is selected, the star is still shown. I think it stands out too much and adds clutter. Also it looked a bit confusing when I first saw it. Could you try to hide it when the spinner list closed. It may be possible to do so from AdapterView.OnItemSelectedListener.onItemSelected. If it's not possible, I'd rather not show it for now. Please, let me know if you need any help with this. |
|
I think you are right, I'll look into it this weekend probably. Thanks! |
|
Thanks! Merged. |
3 participants
This is a series of commits that puts the favorite accounts on top of the other accounts transfer accounts list. It makes it easier to add transactions if you use some transfer accounts more frequently.
I was annoyed at the app because I only really use two transfer accounts and I had to scroll through all my accouts to get to my credit card.
To avoid any confusion, I made it so that the favorite "star" would show beside the name of the transfer accounts that are favorite. That way the user knows why they appear first.
Thanks for the consideration!