[unique.ptr.single] Remove redundant preconditions after 079f7d3b02d#4871
[unique.ptr.single] Remove redundant preconditions after 079f7d3b02d#4871JohelEGP wants to merge 1 commit into
Conversation
|
This doesn't look right. "noexcept" means no exception escapes, but violating a precondition (e.g. when moving a deleter throws) is still undefined behavior. Can you show which normative statement implies the struck text? |
|
There's none. My assumption was that the precondition existed to prevent users from examining the This is definitely not editorial, though. If you agree, I'll close this PR and its issue, and consider submitting an LWG issue. |
|
Well, for once, having to catch all exceptions to call terminate for a noexcept violation is overhead you might want to avoid. (We don't require the deleter's move operation to be declared noexcept, we just require that it does not throw an exception for this particular move invocation.) Anyway, this is not editorial, so I'd appreciate if you closed this issue and submitted an LWG issue if you believe there is a defect in the specification (I don't believe so). |
The compiler is going to provide the
Yes, this should be an LWG issue. |
|
It would be nice to have the link to this draft PULL request as part of the corresponding LWG issue submission text. |
Would that be the case even though there are more signatures that are |
|
I only recommend that when an LWG issue is submitted as a consequence and strong relation to an issue/pull request from this project, it would be nice to refer to that issue/pull request in the text of the LWG issue submission. |
Resolves #4872.