[res.on.data.races] Use "object parameter" instead of this or "argument"#6748
Closed
frederick-vs-ja wants to merge 1 commit into
Closed
[res.on.data.races] Use "object parameter" instead of this or "argument"#6748frederick-vs-ja wants to merge 1 commit into
this or "argument"#6748frederick-vs-ja wants to merge 1 commit into
Conversation
Quuxplusone
reviewed
Dec 28, 2023
frederick-vs-ja
force-pushed
the
dereference-this
branch
from
0184666 to
c12925f
Compare
Member
|
The this -> *this changes look good to me (we're not doing anything with the pointer). I'm hesitant about the argument -> parameter change. The core language part needs CWG review, I think. Could you please split out the former two categories into two separate pull requests? |
frederick-vs-ja
force-pushed
the
dereference-this
branch
from
c12925f to
ed8b014
Compare
frederick-vs-ja
changed the title
thisthis or "argument"
Contributor
Author
Done. The core part and the pure |
Contributor
|
@jensmaurer Shall we close this now as not editorial? |
Member
|
Yeah, I think I want to see more motivation here. |
Contributor
Author
|
LWG4129 opened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should say "implicit object parameter", "implied object argument", or "
*this" instead.(Attempted to fix) #6731.