[charconv.from.chars] Clarify effect of from_chars#6833
Closed
eisenwave wants to merge 1 commit into
Closed
Conversation
Contributor
I don't believe they should furtherly match. It doesn't seem intended the character sequence would be parsed as another floating-point type and then converted to the target type. |
Member
Contributor
|
This should be done via an LWG issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6730.
Drafting the wording has revealed an asymmetry with how
static_castworks. Say we have a floating-point typeTwhich cannot represent infinity and which can represent[-1, 1]in increments of0.1.In that case,
static_cast<T>(1.1)is undefined behavior. However,from_chars("1.1")in the current wording is1.0. My proposed change is editorial only and doesn't change that behavior, but perhaps it should be revisited whetherstatic_castandfrom_charsshould have matching behavior in this event.