Github action and Requirement.txt #11
Conversation
|
|
| pip install -r requirements.txt | ||
| - name: Lint with flake8 | ||
| run: | | ||
| pip install flake8 |
There was a problem hiding this comment.
I would move this flake8 install step to Install dependencies
| @@ -0,0 +1,34 @@ | |||
| name: Python package | |||
|
|
|||
| on: [push] | |||
There was a problem hiding this comment.
Please specify the target branches like below.
on:
push:
branches:
- master
tags:
- v*
pull_request:
branches:
- master
| strategy: | ||
| max-parallel: 4 | ||
| matrix: | ||
| python-version: [2.7, 3.5, 3.6, 3.7] |
There was a problem hiding this comment.
It will start 4 different VMs. Do we need 4 different versions for linting and test? I would use one py 3.7 for this ci.
@amanbha @yaron2 @brendandburns Do we expect that dapr py-sdk supports python 2.x ?
There was a problem hiding this comment.
I will change it to 3.7 only.
I agree @youngbupark , since python 2.x is retiring in 1 month 23 days from now [ https://pythonclock.org/ ] , it will be better to remove 2.x .
|
@rajibmitra Any updates on this pr ? |
|
@rmitr any updates on this PR? |
|
@rmitr closing it for now due to lack of response. Please feel free to reopen when you are working on it. |
4 participants
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
#9 #10