Skip to content

fix(pf4): wizard disable next button when validating#424

Merged
Hyperkid123 merged 1 commit into
data-driven-forms:v1from
rvsia:pf4wizardValidate
Apr 14, 2020
Merged

fix(pf4): wizard disable next button when validating#424
Hyperkid123 merged 1 commit into
data-driven-forms:v1from
rvsia:pf4wizardValidate

Conversation

@rvsia

@rvsia rvsia commented Apr 9, 2020

Copy link
Copy Markdown
Contributor

Async validation should disable the next button

@rvsia rvsia added bug Something isn't working PF4 PF4 pull request V1 backports for V1 labels Apr 9, 2020
@rvsia rvsia force-pushed the pf4wizardValidate branch from b0a223e to 3d67a02 Compare April 9, 2020 14:28
@rvsia rvsia force-pushed the pf4wizardValidate branch from 3d67a02 to 83a98cb Compare April 9, 2020 14:37
@rvsia rvsia requested a review from Hyperkid123 April 9, 2020 14:38
@codecov

codecov Bot commented Apr 9, 2020

Copy link
Copy Markdown

Codecov Report

Merging #424 into v1 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #424   +/-   ##
=======================================
  Coverage   91.64%   91.65%           
=======================================
  Files         100      100           
  Lines        2035     2037    +2     
  Branches      673      674    +1     
=======================================
+ Hits         1865     1867    +2     
  Misses        170      170           
Impacted Files Coverage Δ
...-component-mapper/src/form-fields/wizard/wizard.js 100.00% <ø> (ø)
...nent-mapper/src/form-fields/wizard/step-buttons.js 94.11% <100.00%> (+0.36%) ⬆️
...onent-mapper/src/form-fields/wizard/wizard-step.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 298795d...83a98cb. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 3c11099 into data-driven-forms:v1 Apr 14, 2020
@rvsia rvsia deleted the pf4wizardValidate branch April 28, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PF4 PF4 pull request V1 backports for V1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants