Skip to content

fix(pf4): add styling for disabled options#452

Merged
Hyperkid123 merged 1 commit into
data-driven-forms:v1from
rvsia:disabledSelectPF4
Apr 24, 2020
Merged

fix(pf4): add styling for disabled options#452
Hyperkid123 merged 1 commit into
data-driven-forms:v1from
rvsia:disabledSelectPF4

Conversation

@rvsia

@rvsia rvsia commented Apr 24, 2020

Copy link
Copy Markdown
Contributor

selectdisable

Disabled option was missing styling, done according to PF select component.

@rvsia rvsia added bug Something isn't working PF4 PF4 pull request V1 backports for V1 labels Apr 24, 2020
@rvsia rvsia requested a review from Hyperkid123 April 24, 2020 11:15
@codecov

codecov Bot commented Apr 24, 2020

Copy link
Copy Markdown

Codecov Report

Merging #452 into v1 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #452   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         100      100           
  Lines        2037     2037           
  Branches      674      674           
=======================================
  Hits         1867     1867           
  Misses        170      170           
Impacted Files Coverage Δ
...-component-mapper/src/form-fields/select/option.js 58.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c11099...292f1d6. Read the comment docs.

@Hyperkid123 Hyperkid123 merged commit 0f41a43 into data-driven-forms:v1 Apr 24, 2020
@Hyperkid123

Copy link
Copy Markdown
Member

released in @data-driven-forms/pf4-component-mapper@1.31.3

@rvsia rvsia deleted the disabledSelectPF4 branch April 28, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PF4 PF4 pull request V1 backports for V1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants