Named parameters support#200
Closed
mattdeekay wants to merge 7 commits into
Closed
Conversation
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
mattdeekay
requested review from
andrefurlan-db,
arikfr,
susodapop and
yunbodeng-db
as code owners
Signed-off-by: Matthew Kim <11141331+mattdeekay@users.noreply.github.com>
mattdeekay
force-pushed
the
named-parameters
branch
from
eb30cfd to
4a1c59d
Compare
andrefurlan-db
left a comment
andrefurlan-db
left a comment
Contributor
There was a problem hiding this comment.
please make sure that parameterized query support is consistent across all drivers/connectors. @rcypher-databricks needs to review and make sure it is. Specially data type handling stuff
| ) | ||
|
|
||
| def execute( | ||
| self, operation: str, parameters: Optional[Dict[str, str]] = None |
There was a problem hiding this comment.
If we allowed users to do this I think we should continue to support it, but instead of injecting the parameter values in the driver we should convert to the format expected by the backend and pass it on.
| return spark_params | ||
|
|
||
| @staticmethod | ||
| def get_type_and_value(value: Any) -> (str, TSparkParameterValue): |
There was a problem hiding this comment.
We need to have more comprehensive handling of types. There needs to be a way for a user to specify the desired sql type of the parameter value.
Contributor
|
Closing as this was implemented in #217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports server-side named query parameterization. Client will need to call execute like this:
This removes client-side query injection that was a facade for query parameterization while the server-side support was still under development.