Skip to content

Revert "[PECO-1083] Updated thrift files and added check for protocol version" #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susodapop merged 1 commit into from
Oct 2, 2023
Merged

Revert "[PECO-1083] Updated thrift files and added check for protocol version" #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/databricks/sql/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import requests
import json
import os
from databricks.sql.thrift_api.TCLIService import ttypes

from databricks.sql import __version__
from databricks.sql import *
Expand Down Expand Up @@ -226,11 +225,6 @@ def __del__(self):
def get_session_id(self):
return self.thrift_backend.handle_to_id(self._session_handle)

def get_session_protocol_version(self):
return self.thrift_backend.extract_protocol_version_from_handle(
self._session_handle
)

def get_session_id_hex(self):
return self.thrift_backend.handle_to_hex_id(self._session_handle)

Expand Down Expand Up @@ -507,13 +501,6 @@ def execute(
"""
if parameters is None:
parameters = []
elif (
self.connection.get_session_protocol_version()
< ttypes.TProtocolVersion.SPARK_CLI_SERVICE_PROTOCOL_V8
):
raise Error(
"Parameterized operations are not supported by this server. DBR 14.1 is required."
)
else:
parameters = named_parameters_to_tsparkparams(parameters)

Expand Down
Loading