Skip to content
This repository was archived by the owner on Mar 16, 2022. It is now read-only.

Fix setting visible window#63

Merged
5 commits merged into
developfrom
clehner/62_fix_setting_visible_window
Jun 29, 2020
Merged

Fix setting visible window#63
5 commits merged into
developfrom
clehner/62_fix_setting_visible_window

Conversation

@lehnerchristian

@lehnerchristian lehnerchristian commented Jun 25, 2020

Copy link
Copy Markdown

closes #62

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted
  • tested with Firefox 52, Firefox 57+, Chrome 64+, MS Edge 16+

Summary

The problem was that the range2transform function did not consider that in the y axis the coordinates are reversed (screen coords vs. data coords).

@lehnerchristian lehnerchristian requested a review from a user June 25, 2020 14:36
@lehnerchristian lehnerchristian assigned ghost Jun 25, 2020
@ghost ghost merged commit 3216d9c into develop Jun 29, 2020
@ghost ghost deleted the clehner/62_fix_setting_visible_window branch June 29, 2020 08:18
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant