packages/cli/package.json (1)

51-51: ⚠️ Potential issue | 🟠 Major

Declare the Node floor with this major bump.

Shiki v4 drops Node 18 support and requires Node.js 20+, but this public package still omits engines.node. That leaves consumers able to install an unsupported runtime with no manifest warning. Add an engines.node entry here, ideally matching the repo-wide floor if it is already higher. (shiki.style)

#!/bin/bash
set -euo pipefail

echo "== package.json files and engines.node =="
python - <<'PY'
import json, pathlib
for f in sorted(pathlib.Path('.').rglob('package.json')):
    if 'node_modules' in f.parts or 'dist' in f.parts:
        continue
    data = json.loads(f.read_text())
    engine = data.get('engines', {}).get('node', '<none>')
    print(f"{f}: {engine}")
PY

echo
echo "== packages/cli usages of `@shikijs/cli` =="
rg -n -C2 --glob '!**/dist/**' --glob '!**/node_modules/**' '@shikijs/cli|codeToANSI|\bshiki\b|\bskat\b' packages/cli

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/cli/package.json` at line 51, Add an engines.node field to the
packages/cli package.json to declare the Node.js minimum (e.g., ">=20") so
consumers get a manifest warning; update the package.json that lists
"@shikijs/cli" to include an "engines" object with "node" set to the repo-wide
floor (match other package.json files if they already set a higher floor) and
ensure package metadata remains valid for publishing.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

packages/cli/package.json (1)

51-51: ⚠️ Potential issue | 🟠 Major

Declare Node engine compatibility for this major bump.

@shikijs/cli@^4 drops older Node support. Without a package-level engines.node, this package can be installed on unsupported Node versions and fail later at runtime. Add an engines constraint here aligned with the repo root policy.

#!/bin/bash
set -euo pipefail

echo "== root Node engine policy =="
cat package.json | jq -r '.engines.node // "NO_ROOT_ENGINES_NODE"'

echo
echo "== package-level engines in packages/*/package.json =="
fd '^package\.json$' packages | xargs jq -r '
  . as $p
  | input_filename + " -> " + (.engines.node // "NO_ENGINES_NODE")
'

echo
echo "== confirm updated dependency =="
jq -r '.dependencies["@shikijs/cli"] // "NOT_FOUND"' packages/cli/package.json

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/cli/package.json` at line 51, The package declares the new
dependency "@shikijs/cli": "^4.0.0" which drops older Node versions but
package.json lacks an engines.node constraint; add an "engines": { "node":
"<root's engines.node constraint>" } entry to this package's package.json (use
the same node range as the repo root policy) so installs on unsupported Node
versions are prevented and the package-level engines aligns with the repo root.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

packages/cli/package.json (1)

51-51: ⚠️ Potential issue | 🔴 Critical

Breaking change: codeToANSI now async—calls need await.

The existing review comment correctly identifies that codeToANSI returns Promise<string> in v4. The code at packages/cli/src/commands/cat.ts:287,290 still calls it without await, causing highlightContent to return Promise<string> instead of string.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/cli/package.json` at line 51, The helper highlightContent currently
calls codeToANSI (which is async) without awaiting it, causing highlightContent
to return a Promise instead of a string; update highlightContent to be async and
await the codeToANSI call (and any other codeToANSI invocations) so it returns a
resolved string, and propagate async/await to any callers (e.g., callers of
highlightContent) or await the returned Promise where used; reference the
functions codeToANSI and highlightContent and ensure their signatures are
adjusted (add async to highlightContent) and all call sites are updated to use
await.

packages/cli/package.json (1)

51-51: ⚠️ Potential issue | 🟠 Major

Major upgrade needs compatibility proof before merge.

This bump is v3 → v4 with documented breaking changes, but this PR only updates the manifest. Please verify CLI call sites (especially codeToANSI) and Node runtime floor before merging.

#!/bin/bash
set -euo pipefail

echo "== 1) Find `@shikijs/cli` imports and codeToANSI call sites =="
rg -n -C2 --type=ts "from '@shikijs/cli'|\\bcodeToANSI\\s*\\(" packages/cli/src

echo
echo "== 2) Check whether call sites are awaited (quick heuristic) =="
rg -n -C2 --type=ts "await\\s+codeToANSI\\s*\\(|\\bcodeToANSI\\s*\\(" packages/cli/src

echo
echo "== 3) Confirm declared Node engine constraints (root + package) =="
rg -n -C2 "\"engines\"|\"node\"" package.json packages/cli/package.json || true

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/cli/package.json` at line 51, This PR only bumps "@shikijs/cli" to
v4 but v4 has breaking changes—verify compatibility by locating all imports from
'@shikijs/cli' and every call site of codeToANSI (symbol: codeToANSI) across
packages/cli/src to confirm the function signature and behavior haven't changed,
ensure call sites handle any new async return (i.e., are awaited if v4 returns a
Promise), and update affected call sites accordingly; also confirm and, if
needed, raise the declared Node engine floor in package.json and
packages/cli/package.json to meet v4's runtime requirement, then add a short
note in the commit/PR describing the checked call sites and engine change as
proof of compatibility.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes