Remove unneeded re.U/re.UNICODE flags#197
Merged
Merged
Conversation
Python 2 support was dropped, and in Python 3 str patterns are Unicode-aware by default, making re.U/re.UNICODE a no-op. Strip it from the compiled regexes in config and the tests that mirror them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
re.U/re.UNICODEis a no-op in Python 3 sincestrpatterns are already Unicode-aware by default (it only matters forbytespatterns, which this project doesn't use). It was a leftover from the Python 2 era.re.U/re.UNICODEoccurrences fromnameparser/config/regexes.pyand the test files that mirror those patterns (tests/test_python_api.py,tests/test_nicknames.py,tests/test_constants.py).Test plan
python3 -m pytest -q— 1074 passed, 4 skipped, 22 xfailed (same as before the change)🤖 Generated with Claude Code