Skip to content

dev: Update django tests (test django against latest)#2021

Open
kingbuzzman wants to merge 17 commits into
django-haystack:masterfrom
kingbuzzman:dev/update-django-next
Open

dev: Update django tests (test django against latest)#2021
kingbuzzman wants to merge 17 commits into
django-haystack:masterfrom
kingbuzzman:dev/update-django-next

Conversation

@kingbuzzman

@kingbuzzman kingbuzzman commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Please squash

Updates the Django Haystack project's configuration to simplify and modernize the test matrix setup by replacing verbose naming conventions with abbreviated ones and adding support for Django's main branch.

  • Simplifies tox environment naming from django{4.2,5.1,5.2} to dj{42,51,52,main}
  • Removes GitHub Actions environment variables and refactors dependency management
  • Adds Django main branch support for testing against the latest development version

@kingbuzzman kingbuzzman changed the title dev: Update django tests (test against latest) dev: Update django tests (test django against latest) Aug 19, 2025
@kingbuzzman kingbuzzman marked this pull request as ready for review August 19, 2025 18:20
Comment thread tox.ini
envlist =
docs
py{39,310,311,312,313}-django{4.2,5.1,5.2}-es7.x
py{39,310,311,312,313}-dj{42,51,52,main}-es7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we have not tracked main because there have been periods where changes broke builds for a while. I'm wondering whether we want to allow main to fail, or whether that's no longer necessary because the Django project is pretty mature and we're not making changes as rapidly on Haystack either.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my perspective; Github CI is kinda wonky when it comes to allowing things to fail, it wont be obvious that it is failing, and it will be a "out of sight, out of mind", and that is kinda scary.

@kingbuzzman kingbuzzman Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My position is that we should test supported versions of Python (5 versions) times Django (3 versions) but not unsupported versions. We should not encourage users to run production infrastructure on unsupported software.

@cclauss so you're against running on CI, but not locally? Am i understanding you correctly?

PS. This is more of a "heads up", this is what is going to break in 6m-1y time, but you're the maintainers. Up to you.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always run 5 Py * 3 Dj on CI for all PRs and code changes.

@kingbuzzman kingbuzzman Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always run 5 Py * 3 Dj on CI for all PRs and code changes.

so, you want to remove main.

what do you think about:

This is more of a "heads up", this is what is going to break in 6m-1y time

as in, sooner or later you need to maintain this, this way it gives you a heads up instead of a bomb at your doorstep that there is an incompatibility.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss thoughts ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss I guess we have different definitions of

unsupported versions

or

unsupported software.

This is not versions that have been dropped, but instead are in active development and will be valid version in a not too far along future. This allows you to see what is coming down the pipeline before the actual release causes you alarm. What can happen here is to have this version not be [required] and if it fails is fine, you can still merge the PR (all this is configured in the github settings)

acdha
acdha previously approved these changes Aug 19, 2025
@cclauss

cclauss commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

My position is that we should test supported versions of Python (5 versions) times Django (3 versions) but not unsupported versions. We should not encourage users to run production infrastructure on unsupported software.

@cclauss

cclauss commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

This branch is out-of-date with the base branch

@kingbuzzman

Copy link
Copy Markdown
Contributor Author

@cclauss apologies, completely missed this comment. Where did we leave off with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants