feat: save and load inmemory index#1534
Merged
Merged
Conversation
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
JoanFM
approved these changes
May 15, 2023
Member
|
I would like to have this also for hnsw one? or it already behaves like this? |
Contributor
Author
|
@JoanFM hnsw's already cool, it updates index after each change and can load from existing workdir |
samsja
approved these changes
May 15, 2023
Member
|
@jupyterjazz should we adapt the LangChain integration? |
JoanFM
requested changes
May 15, 2023
JoanFM
left a comment
JoanFM
left a comment
Member
There was a problem hiding this comment.
Should we rename the method? I believe binary provides no value here.
WDYT @samsja @jupyterjazz @JohannesMessner ?
| ) -> _FindResultBatched: | ||
| raise NotImplementedError(f'{type(self)} does not support text search.') | ||
|
|
||
| def save_binary(self, file: str = 'in_memory_index.bin') -> None: |
Member
There was a problem hiding this comment.
Suggested change
| def save_binary(self, file: str = 'in_memory_index.bin') -> None: | |
| def persist(self, file: str = 'in_memory_index.bin') -> None: |
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Contributor
Author
langchain doesn't need loading from a binary file |
JoanFM
approved these changes
May 15, 2023
|
📝 Docs are deployed on https://ft-feat-save-inmemory--jina-docs.netlify.app 🎉 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1535