Skip to content

refactor: uncaped tests as a nightly job#1540

Merged
samsja merged 11 commits into
mainfrom
fix-slow-uncaped-jobs
May 16, 2023
Merged

refactor: uncaped tests as a nightly job#1540
samsja merged 11 commits into
mainfrom
fix-slow-uncaped-jobs

Conversation

@jupyterjazz

@jupyterjazz jupyterjazz commented May 15, 2023

Copy link
Copy Markdown
Contributor

Since uncaped tests take longer, let's separate them from CI and run them as nightly jobs

Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
@github-actions github-actions Bot added size/s and removed size/xs labels May 15, 2023
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
@jupyterjazz jupyterjazz requested a review from samsja May 15, 2023 15:38
@jupyterjazz jupyterjazz changed the title refactor: run uncaped tests once every 10 runs refactor: uncaped tests as a nightly job May 15, 2023
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
@github-actions github-actions Bot added size/m and removed size/s labels May 15, 2023
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
@github-actions github-actions Bot added size/s and removed size/m labels May 15, 2023
Comment thread .github/workflows/uncaped.yml Outdated
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
@jupyterjazz jupyterjazz requested a review from samsja May 15, 2023 18:32
@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-slow-uncaped-jobs--jina-docs.netlify.app 🎉


on:
schedule:
- cron: '0 0,1 * * *' # Run at midnight, 1 AM UTC

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it is okay to make the CI run at midnight, poor runner need to sleep no ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

@samsja samsja merged commit 0bcc956 into main May 16, 2023
@samsja samsja deleted the fix-slow-uncaped-jobs branch May 16, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants