fix: fix None embedding exact nn search#1575
Merged
Merged
Conversation
JoanFM
force-pushed
the
fix-filter-None-embeddings
branch
from
dadb515 to
3f794be
Compare
JoanFM
requested review from
JohannesMessner and
jupyterjazz
and removed request for
JohannesMessner
JoanFM
force-pushed
the
fix-filter-None-embeddings
branch
from
3f794be to
962a96a
Compare
jupyterjazz
reviewed
May 24, 2023
JoanFM
force-pushed
the
fix-filter-None-embeddings
branch
2 times, most recently
from
4fa6321 to
e9a5d75
Compare
JohannesMessner
requested changes
May 24, 2023
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
fix-filter-None-embeddings
branch
from
e9a5d75 to
0c84598
Compare
JohannesMessner
approved these changes
May 26, 2023
samsja
approved these changes
May 26, 2023
jupyterjazz
reviewed
May 26, 2023
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
|
📝 Docs are deployed on https://ft-fix-filter-None-embeddings--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR filters out None embeddings when computing the index matrix before doing the NN search in
findmethod