Skip to content

fix: dynamically resize internal index to adapt to increasing number of docs#1602

Merged
JoanFM merged 3 commits into
mainfrom
fix-resize-hnswlib-index
Jun 1, 2023
Merged

fix: dynamically resize internal index to adapt to increasing number of docs#1602
JoanFM merged 3 commits into
mainfrom
fix-resize-hnswlib-index

Conversation

@JoanFM

@JoanFM JoanFM commented May 31, 2023

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM JoanFM force-pushed the fix-resize-hnswlib-index branch from 73017fd to a348fff Compare May 31, 2023 14:36
@JoanFM JoanFM changed the title fix: resize hnswlib index fix: dynamically resize internal index to adapt to increasing number of docs May 31, 2023
@JoanFM JoanFM requested a review from samsja May 31, 2023 16:39

@samsja samsja left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we had this behavior in the docstring or/and in the docs ?

Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM

JoanFM commented Jun 1, 2023

Copy link
Copy Markdown
Member Author

Recheck please!

@JoanFM JoanFM requested a review from samsja June 1, 2023 07:09
Comment thread docs/user_guide/storing/index_hnswlib.md Outdated
@JoanFM JoanFM requested a review from samsja June 1, 2023 07:20
Co-authored-by: samsja <55492238+samsja@users.noreply.github.com>
Signed-off-by: Joan Fontanals <jfontanalsmartinez@gmail.com>
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM JoanFM force-pushed the fix-resize-hnswlib-index branch from 2d4b0be to 08f7e84 Compare June 1, 2023 07:25
@github-actions

github-actions Bot commented Jun 1, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-resize-hnswlib-index--jina-docs.netlify.app 🎉

@JoanFM JoanFM merged commit 3cef708 into main Jun 1, 2023
@JoanFM JoanFM deleted the fix-resize-hnswlib-index branch June 1, 2023 08:00
@samsja samsja mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle max_elements from HNSWLibIndexer

2 participants