fix: allow update on HNSWLibIndex#1604
Merged
Merged
Conversation
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
fix-update-hnswlib-index
branch
from
bf49d1c to
86cc22a
Compare
JoanFM
changed the title
samsja
reviewed
Jun 1, 2023
samsja
requested changes
Jun 1, 2023
samsja
left a comment
samsja
left a comment
Member
There was a problem hiding this comment.
Is it possible to have a code snippet in docs ?
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
Member
Author
Can u recheck? |
jupyterjazz
reviewed
Jun 1, 2023
| ``` | ||
|
|
||
| Check [here](docindex#nested-data-with-subindex) for nested data with subindex. No newline at end of file | ||
| Check [here](docindex#nested-data-with-subindex) for nested data with subindex. |
Contributor
There was a problem hiding this comment.
this link doesn't work let's remove it
I'll add subindex feature info in a separate pr
| text: str | ||
| embedding: NdArray[128] | ||
|
|
||
| docs = DocList[MyDoc]( |
Contributor
There was a problem hiding this comment.
I'd show an example where we retrieve some data (find, filter..) and replace only those docs, otherwise I don't think this is a relatable example
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
jupyterjazz
approved these changes
Jun 1, 2023
samsja
reviewed
Jun 1, 2023
samsja
approved these changes
Jun 1, 2023
|
📝 Docs are deployed on https://ft-fix-update-hnswlib-index--jina-docs.netlify.app 🎉 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.