Skip to content

fix: filter limits#1618

Merged
JoanFM merged 2 commits into
mainfrom
fix-filtering-limit
Jun 6, 2023
Merged

fix: filter limits#1618
JoanFM merged 2 commits into
mainfrom
fix-filtering-limit

Conversation

@jupyterjazz

Copy link
Copy Markdown
Contributor

We allow passing filter limits but never use in a couple of places.

Fix filter limits in:

  • InMemory index filter
  • InMemory index hybrid search
  • Hnsw hybrid search

Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
Signed-off-by: jupyterjazz <saba.sturua@jina.ai>
@jupyterjazz jupyterjazz linked an issue Jun 5, 2023 that may be closed by this pull request
@github-actions

github-actions Bot commented Jun 5, 2023

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-filtering-limit--jina-docs.netlify.app 🎉

Comment thread docarray/index/backends/helper.py
@JoanFM JoanFM merged commit f7371b4 into main Jun 6, 2023
@JoanFM JoanFM deleted the fix-filtering-limit branch June 6, 2023 08:49
@samsja samsja mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: limit doesn't work for InMemoryExactNNIndex filtering

2 participants