fix: default column config should be DBConfig and not RuntimeConfig#1648
Merged
Conversation
JoanFM
changed the title
…runtime-config Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
fix-runtime-config
branch
from
d34dab0 to
cdfbbeb
Compare
Member
|
Can we make this a non-breaking change for a few versions? And raise a warning? |
Member
Author
What is breaking in your opinion? I do not see what can be breaking? |
Member
If I pass a RuntimeConfig from before (still containing default_column_config) to configure, does it raise an exception or something? If not it is fine |
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
JohannesMessner
approved these changes
Jun 14, 2023
Signed-off-by: Johannes Messner <messnerjo@gmail.com> Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
fix-runtime-config
branch
from
11d6bd6 to
322a25a
Compare
|
📝 Docs are deployed on https://ft-fix-runtime-config--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.