fix: pass limit as integer#1656
Merged
Merged
Conversation
JoanFM
force-pushed
the
chore-limit-pass-int
branch
from
41065de to
ca7d599
Compare
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
chore-limit-pass-int
branch
from
ca7d599 to
72d04d0
Compare
JoanFM
requested review from
JohannesMessner,
alaeddine-13,
jupyterjazz and
samsja
|
📝 Docs are deployed on https://ft-chore-limit-pass-int--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to wrap the InMemoryExactNNIndexer as an Executor in Jina and passing limits as parameters they are passed as
floatsbecause of protobuf. So it would be good for us to have this change applied otherwise it raises an exception