Skip to content

fix: encode and decode only once#223

Merged
alaeddine-13 merged 2 commits into
mainfrom
fix-blob-encode
Mar 24, 2022
Merged

fix: encode and decode only once#223
alaeddine-13 merged 2 commits into
mainfrom
fix-blob-encode

Conversation

@alaeddine-13

Copy link
Copy Markdown
Member

closes: #221

Comment thread docarray/document/mixins/pydantic.py Outdated
@codecov

codecov Bot commented Mar 24, 2022

Copy link
Copy Markdown

Codecov Report

Merging #223 (58b1941) into main (5a8544a) will increase coverage by 4.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   81.18%   85.31%   +4.13%     
==========================================
  Files         123      123              
  Lines        5677     5674       -3     
==========================================
+ Hits         4609     4841     +232     
+ Misses       1068      833     -235     
Flag Coverage Δ
docarray 85.31% <100.00%> (+4.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/document/mixins/pydantic.py 88.88% <100.00%> (+0.42%) ⬆️
docarray/document/pydantic_model.py 97.67% <100.00%> (+1.84%) ⬆️
docarray/document/mixins/_property.py 85.80% <0.00%> (+4.51%) ⬆️
docarray/array/mixins/traverse.py 95.86% <0.00%> (+5.78%) ⬆️
docarray/proto/io/__init__.py 91.80% <0.00%> (+22.95%) ⬆️
docarray/types/deserializers.py 73.91% <0.00%> (+43.47%) ⬆️
docarray/types/multimodal.py 88.54% <0.00%> (+66.66%) ⬆️
docarray/document/mixins/multimodal.py 91.13% <0.00%> (+68.35%) ⬆️
docarray/document/mixins/plot.py 85.71% <0.00%> (+70.12%) ⬆️
docarray/types/serializers.py 97.05% <0.00%> (+70.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8544a...58b1941. Read the comment docs.

@numb3r3 numb3r3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaeddine-13 alaeddine-13 merged commit 2eee6c5 into main Mar 24, 2022
@alaeddine-13 alaeddine-13 deleted the fix-blob-encode branch March 24, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in to_pydantic_model/from_pydantic_model

2 participants