feat(hubble): push/pull user authentication#238
Conversation
Codecov Report
@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 86.02% 86.09% +0.07%
==========================================
Files 134 135 +1
Lines 6090 6129 +39
==========================================
+ Hits 5239 5277 +38
- Misses 851 852 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hanxiao
left a comment
hanxiao
left a comment
There was a problem hiding this comment.
user journey needs redesign, right now token and id is so confusing
delgermurun
force-pushed
the
feat-hubble-user-auth
branch
3 times, most recently
from
1d9a084 to
ab8dfc8
Compare
|
|
||
| res = requests.post( | ||
| f'{_get_cloud_api()}/v2/rpc/da.push', data=gen(), headers=headers | ||
| f'{_get_cloud_api()}/v2/rpc/artifact.upload', data=gen(), headers=headers |
There was a problem hiding this comment.
I'm just wondering here why the API endpoint was renamed from da.push to artifact.upload
Isn't artifact related to finetuner ?
There was a problem hiding this comment.
Not specifically related to finetuner. Under the hood, every types of storage will use Hub's artifact storage system.
Doesn't matter docarray, finetuner model, or anything else in the future.
delgermurun
force-pushed
the
feat-hubble-user-auth
branch
from
ab8dfc8 to
60e5784
Compare
| raise FileNotFoundError( | ||
| f'can not find `{token}` DocumentArray on the Cloud. Misspelled?' | ||
| json_res = response.json() | ||
| raise Exception( |
There was a problem hiding this comment.
| raise Exception( | |
| raise ObjectNotFoundError( |
and let's create a docarray/exceptions.py module and include such an error
delgermurun
force-pushed
the
feat-hubble-user-auth
branch
from
60e5784 to
3717d6e
Compare
3 participants
Related https://github.com/jina-ai/hubble/issues/353