Skip to content

refactor(dataclass): fix types registry to lambda#252

Merged
hanxiao merged 7 commits into
mainfrom
refactor-dataclass-field
Apr 4, 2022
Merged

refactor(dataclass): fix types registry to lambda#252
hanxiao merged 7 commits into
mainfrom
refactor-dataclass-field

Conversation

@hanxiao

@hanxiao hanxiao commented Apr 4, 2022

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Apr 4, 2022

Copy link
Copy Markdown

Codecov Report

Merging #252 (e83d696) into main (d1ed429) will decrease coverage by 2.40%.
The diff coverage is 97.40%.

@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
- Coverage   86.00%   83.59%   -2.41%     
==========================================
  Files         134      134              
  Lines        6081     6090       +9     
==========================================
- Hits         5230     5091     -139     
- Misses        851      999     +148     
Flag Coverage Δ
docarray 83.59% <97.40%> (-2.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/dataclasses/types.py 89.09% <96.66%> (+0.74%) ⬆️
docarray/dataclasses/setter.py 97.29% <97.29%> (ø)
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/dataclasses/__init__.py 100.00% <100.00%> (ø)
docarray/dataclasses/getter.py 91.30% <100.00%> (ø)
docarray/document/mixins/multimodal.py 93.24% <100.00%> (-0.10%) ⬇️
docarray/array/mixins/embed.py 10.52% <0.00%> (-78.95%) ⬇️
docarray/array/storage/memory/find.py 41.81% <0.00%> (-49.10%) ⬇️
docarray/math/distance/__init__.py 25.75% <0.00%> (-34.85%) ⬇️
docarray/array/mixins/group.py 69.23% <0.00%> (-17.95%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ed429...e83d696. Read the comment docs.

@github-actions github-actions Bot added size/m and removed size/s labels Apr 4, 2022
@hanxiao hanxiao merged commit 50c14b1 into main Apr 4, 2022
@hanxiao hanxiao deleted the refactor-dataclass-field branch April 4, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant