Skip to content

refactor(dataclass): allow dataclass takes obj directly#253

Merged
hanxiao merged 2 commits into
mainfrom
refactor-ds-init
Apr 5, 2022
Merged

refactor(dataclass): allow dataclass takes obj directly#253
hanxiao merged 2 commits into
mainfrom
refactor-ds-init

Conversation

@hanxiao

@hanxiao hanxiao commented Apr 5, 2022

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Apr 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #253 (40be013) into main (50c14b1) will increase coverage by 0.08%.
The diff coverage is 96.42%.

❗ Current head 40be013 differs from pull request most recent head aa30cd5. Consider uploading reports for the commit aa30cd5 to get more accurate results

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   86.02%   86.10%   +0.08%     
==========================================
  Files         134      135       +1     
  Lines        6090     6141      +51     
==========================================
+ Hits         5239     5288      +49     
- Misses        851      853       +2     
Flag Coverage Δ
docarray 86.10% <96.42%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/dataclasses/types.py 89.34% <95.45%> (+0.25%) ⬆️
docarray/base.py 98.64% <100.00%> (ø)
docarray/dataclasses/__init__.py 100.00% <100.00%> (ø)
docarray/document/mixins/multimodal.py 93.24% <100.00%> (ø)
docarray/array/mixins/setitem.py 81.81% <0.00%> (ø)
docarray/exceptions.py 100.00% <0.00%> (ø)
docarray/math/ndarray.py 89.65% <0.00%> (+0.60%) ⬆️
docarray/array/mixins/io/pushpull.py 86.73% <0.00%> (+2.52%) ⬆️
docarray/document/__init__.py 77.77% <0.00%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c14b1...aa30cd5. Read the comment docs.

@hanxiao hanxiao marked this pull request as draft April 5, 2022 19:41
@github-actions

github-actions Bot commented Apr 5, 2022

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-refactor-ds-init--jina-docs.netlify.app 🎉

@hanxiao hanxiao marked this pull request as ready for review April 5, 2022 20:38
@hanxiao hanxiao merged commit d532588 into main Apr 5, 2022
@hanxiao hanxiao deleted the refactor-ds-init branch April 5, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant