Skip to content

fix: support underscore in attribute name#259

Merged
alaeddine-13 merged 1 commit into
mainfrom
fix-dataclass-underscore
Apr 7, 2022
Merged

fix: support underscore in attribute name#259
alaeddine-13 merged 1 commit into
mainfrom
fix-dataclass-underscore

Conversation

@alaeddine-13

Copy link
Copy Markdown
Member

fix: support underscore in attribute name

@codecov

codecov Bot commented Apr 7, 2022

Copy link
Copy Markdown

Codecov Report

Merging #259 (84aa29d) into main (c84b9de) will increase coverage by 1.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   85.17%   86.17%   +1.00%     
==========================================
  Files         134      134              
  Lines        6157     6157              
==========================================
+ Hits         5244     5306      +62     
+ Misses        913      851      -62     
Flag Coverage Δ
docarray 86.17% <100.00%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/traverse.py 95.86% <100.00%> (ø)
docarray/array/mixins/io/binary.py 97.45% <0.00%> (+1.27%) ⬆️
docarray/array/mixins/io/pushpull.py 87.23% <0.00%> (+8.51%) ⬆️
docarray/helper.py 81.77% <0.00%> (+13.55%) ⬆️
docarray/array/mixins/post.py 84.37% <0.00%> (+71.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84b9de...84aa29d. Read the comment docs.

@alaeddine-13 alaeddine-13 merged commit 8c7846e into main Apr 7, 2022
@alaeddine-13 alaeddine-13 deleted the fix-dataclass-underscore branch April 7, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant