feat: plot matching sprite func#265
Merged
Merged
Conversation
makram93
changed the title
Codecov Report
@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 85.16% 86.05% +0.89%
==========================================
Files 134 134
Lines 6160 6225 +65
==========================================
+ Hits 5246 5357 +111
+ Misses 914 868 -46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alaeddine-13
reviewed
Apr 7, 2022
bwanglzu
reviewed
Apr 7, 2022
|
@makram93 mybad, |
hanxiao
reviewed
Apr 7, 2022
hanxiao
requested changes
Apr 8, 2022
hanxiao
left a comment
hanxiao
left a comment
Member
There was a problem hiding this comment.
need a doc, subsection under this https://docarray.jina.ai/fundamentals/documentarray/visualization/#image-sprites
hanxiao
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to show matching images in a sprite. The leftmost is the query followed by matching results. There is a gap between the query and its matches to distinguish/differentiate.
