Skip to content

feat: add hnsw params to storage backends#272

Merged
alaeddine-13 merged 6 commits into
mainfrom
feat-backends-hnsw-params
Apr 13, 2022
Merged

feat: add hnsw params to storage backends#272
alaeddine-13 merged 6 commits into
mainfrom
feat-backends-hnsw-params

Conversation

@alaeddine-13

@alaeddine-13 alaeddine-13 commented Apr 12, 2022

Copy link
Copy Markdown
Member

feat: add hnsw params to storage backends

@codecov

codecov Bot commented Apr 12, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #272 (81294ed) into main (f30893d) will increase coverage by 0.00%.
The diff coverage is 91.30%.

❗ Current head 81294ed differs from pull request most recent head df00736. Consider uploading reports for the commit df00736 to get more accurate results

@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   86.04%   86.05%           
=======================================
  Files         134      134           
  Lines        6235     6253   +18     
=======================================
+ Hits         5365     5381   +16     
- Misses        870      872    +2
Flag Coverage Δ
docarray 86.05% <91.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/elastic/backend.py 94.05% <60.00%> (-1.78%) ⬇️
docarray/__init__.py 100.00% <100.00%> (ø)
docarray/array/storage/annlite/backend.py 95.00% <100.00%> (+0.26%) ⬆️
docarray/array/storage/qdrant/backend.py 96.77% <100.00%> (+0.14%) ⬆️
docarray/array/storage/weaviate/backend.py 87.28% <100.00%> (+0.44%) ⬆️
docarray/helper.py 81.94% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fb137...df00736. Read the comment docs.

JoanFM
JoanFM requested changes Apr 12, 2022
View reviewed changes
Comment thread docarray/array/storage/elastic/backend.py
index_name: Optional[str] = None
es_config: Dict[str, Any] = field(default_factory=dict)
batch_size: int = 64
ef_construction: Optional[int] = None

@JoanFM JoanFM Apr 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we put directly the defaults here?

@alaeddine-13 alaeddine-13 Apr 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow up on this thread:
https://jinaai.slack.com/archives/C02AC4T8Y5T/p1649754663487439
Me and the team are with option 1 for the mentioned arguments, lmk your opinion

Comment thread docarray/array/storage/qdrant/backend.py
port: Optional[int] = field(default=6333)
serialize_config: Dict = field(default_factory=dict)
scroll_batch_size: int = 64
ef_construct: Optional[int] = None

@JoanFM JoanFM Apr 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@alaeddine-13 alaeddine-13 force-pushed the feat-backends-hnsw-params branch from 81294ed to df00736 Compare April 13, 2022 12:33
@github-actions

github-actions Bot commented Apr 13, 2022

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-backends-hnsw-params--jina-docs.netlify.app 🎉

@alaeddine-13 alaeddine-13 merged commit 5069dc9 into main Apr 13, 2022
@alaeddine-13 alaeddine-13 deleted the feat-backends-hnsw-params branch April 13, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoanFM JoanFM JoanFM approved these changes

Assignees

No one assigned

Labels

area/core area/docs component/array size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alaeddine-13 @JoanFM