feat: added support for all Weaviate HNSW configuration parameters#341
Conversation
|
Thanks a lot for your PR. |
|
Seems that black test is not passing. Could you run |
The test should now pass |
|
hey @jjlatval , thank you for your contribution. Can you cover the new parameters in the tests in |
|
Hello, now it seems you need to |
Codecov Report
@@ Coverage Diff @@
## main #341 +/- ##
=======================================
Coverage 86.19% 86.19%
=======================================
Files 134 134
Lines 6316 6331 +15
=======================================
+ Hits 5444 5457 +13
- Misses 872 874 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
davidbp
left a comment
davidbp
left a comment
There was a problem hiding this comment.
thanks @alaeddine-13 for adding the documentation, LGTM
3 participants
The biggest reason for this PR is to enable DocArray to import large datasets (2M+ objects) to Weaviate backend (see https://weaviate.io/developers/weaviate/current/architecture/resources.html#imports-slowed-down-after-crossing-2m-objects---what-can-i-do). The current implementation does not allow passing relevant configuration parameters for Weaviate.
This PR adds support for all currently listed Weaviate HNSW parameters based on the documentation available here: https://weaviate.io/developers/weaviate/current/vector-index-plugins/hnsw.html#how-to-use-hnsw-and-parameters