Codecov Report

Merging #394 (c6fbf9a) into main (d559752) will increase coverage by 1.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   84.77%   86.53%   +1.76%     
==========================================
  Files         134      134              
  Lines        6358     6388      +30     
==========================================
+ Hits         5390     5528     +138     
+ Misses        968      860     -108     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae4d63b...c6fbf9a. Read the comment docs.

@lhr0909 I created a mvp example to reproduce your issue outside of Jina Flow:

from typing import TypeVar, List
from docarray import dataclass, field, Document, DocumentArray
from docarray.typing import Image, Text, JSON

TrialImages = TypeVar('TrialImages', bound=str)

def trial_images_setter(value: List[str]) -> Document:
    # TODO: this is still not a multi-modal document, but I think it is fine for now
    doc = Document(modality='trial_images')
    doc.chunks = [Document(uri=uri, modality='image') for uri in value]
    return doc

def trial_images_getter(doc: Document) -> List[str]:
    return [d.uri for d in doc.chunks]

@dataclass
class Lipstick:
    brand: Text
    color: Text
    nickname: Text
    meta: JSON
    product_image: Image
    # nested document for embeddings of skin and lip colors from all the trials
    trial_images: TrialImages = field(setter=trial_images_setter, getter=trial_images_getter, default_factory=[])


lip = Lipstick(brand='nike', color='blue', nickname='nicke', meta={}, product_image='tests/image-data/05978.jpg', trial_images=['http://a.b.c/o.jpeg'])

d = Document(lip)
da = DocumentArray([d])

trial_images = da['@.[trial_images]c']

# serializing
pb = da.to_protobuf()

# deserializing
nda = DocumentArray.from_protobuf(pb)
trial_images = nda['@.[trial_images]c']

Hope this can help you to add a unitest to cover this issue

@lhr0909 I created a mvp example to reproduce your issue outside of Jina Flow:

from typing import TypeVar, List
from docarray import dataclass, field, Document, DocumentArray
from docarray.typing import Image, Text, JSON

TrialImages = TypeVar('TrialImages', bound=str)

def trial_images_setter(value: List[str]) -> Document:
    # TODO: this is still not a multi-modal document, but I think it is fine for now
    doc = Document(modality='trial_images')
    doc.chunks = [Document(uri=uri, modality='image') for uri in value]
    return doc

def trial_images_getter(doc: Document) -> List[str]:
    return [d.uri for d in doc.chunks]

@dataclass
class Lipstick:
    brand: Text
    color: Text
    nickname: Text
    meta: JSON
    product_image: Image
    # nested document for embeddings of skin and lip colors from all the trials
    trial_images: TrialImages = field(setter=trial_images_setter, getter=trial_images_getter, default_factory=[])


lip = Lipstick(brand='nike', color='blue', nickname='nicke', meta={}, product_image='tests/image-data/05978.jpg', trial_images=['http://a.b.c/o.jpeg'])

d = Document(lip)
da = DocumentArray([d])

trial_images = da['@.[trial_images]c']

# serializing
pb = da.to_protobuf()

# deserializing
nda = DocumentArray.from_protobuf(pb)
trial_images = nda['@.[trial_images]c']

Hope this can help you to add a unitest to cover this issue

Yeah about this.. This is a use case built by me, so I know there are other docarray bugs so I have to use other ways to traverse 🤣 . Was gonna raise another bug when my project finishes so.. I don't think I will have time adding unit tests to this, so if the team like @alaeddine-13 can help that'd be great. Cheers.