feat(redis): implement Redis storage backend and unit tests#452
Conversation
JoanFM
left a comment
JoanFM
left a comment
There was a problem hiding this comment.
I think these unit tests are excessive.You are only testing private methods. In general, we should test the public interface. These tests may make changing underlying implementation very hard
|
please also fix the commit messages, see error in |
AnneYang720
force-pushed
the
feat-redis-backend
branch
from
fd01bbf to
0dab0c4
Compare
Codecov Report
@@ Coverage Diff @@
## main #452 +/- ##
==========================================
+ Coverage 86.53% 86.86% +0.32%
==========================================
Files 134 140 +6
Lines 6704 6994 +290
==========================================
+ Hits 5801 6075 +274
- Misses 903 919 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
left a comment
JoanFM
left a comment
There was a problem hiding this comment.
Of all these tests for now I would keep only test_init_storage
|
@AnneYang720 let's commit everything on this branch without creating seperate PRs, we'll make it ready-to-review until everything is here |
alaeddine-13
left a comment
alaeddine-13
left a comment
There was a problem hiding this comment.
Besides the documentation, LGTM, well done !
…into feat-redis-backend
|
|
||
| ### Vector search with filter query | ||
|
|
||
| One can perform Vector Similarity Search based on FLAT or HNSW algorithm and pre-filter results using a filter query that is based on [MongoDB's Query](https://www.mongodb.com/docs/manual/reference/operator/query/). We currently support a subset of those selectors: |
There was a problem hiding this comment.
i wouldn't mention MongoDB here. BTW we can refer it as domain specific language in the future or DSL
There was a problem hiding this comment.
it's fine we already mention it here: https://docarray.jina.ai/fundamentals/documentarray/find/
bwanglzu
left a comment
bwanglzu
left a comment
There was a problem hiding this comment.
great work on the docs! left some minor comments
|
|
||
| ### Vector search with filter query | ||
|
|
||
| One can perform Vector Similarity Search based on FLAT or HNSW algorithm and pre-filter results using a filter query that is based on [MongoDB's Query](https://www.mongodb.com/docs/manual/reference/operator/query/). We currently support a subset of those selectors: |
There was a problem hiding this comment.
it's fine we already mention it here: https://docarray.jina.ai/fundamentals/documentarray/find/
6 participants
This PR will implement Redis storage backend and its unit test according to #445