Skip to content

feat(redis): add logic operators $and and $or in redis#509

Merged
JoanFM merged 18 commits into
docarray:mainfrom
AnneYang720:feat-redis-operator
Sep 8, 2022
Merged

feat(redis): add logic operators $and and $or in redis#509
JoanFM merged 18 commits into
docarray:mainfrom
AnneYang720:feat-redis-operator

Conversation

@AnneYang720

Copy link
Copy Markdown
Contributor

This PR will support logic operators $and and $or in redis according to #501

@codecov

codecov Bot commented Aug 30, 2022

Copy link
Copy Markdown

Codecov Report

Merging #509 (834e09e) into main (fff3ecc) will increase coverage by 0.00%.
The diff coverage is 97.91%.

@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   86.24%   86.25%           
=======================================
  Files         142      142           
  Lines        7036     7048   +12     
=======================================
+ Hits         6068     6079   +11     
- Misses        968      969    +1     
Flag Coverage Δ
docarray 86.25% <97.91%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/storage/redis/find.py 93.97% <97.87%> (-0.40%) ⬇️
docarray/__init__.py 75.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AnneYang720 AnneYang720 marked this pull request as draft August 30, 2022 05:38
Comment thread docarray/array/storage/redis/find.py Outdated
Comment thread docarray/array/storage/redis/find.py Outdated
Comment thread docarray/array/storage/redis/find.py Outdated
Comment thread docarray/array/storage/redis/find.py Outdated
Comment thread tests/unit/array/mixins/test_find.py Outdated
@AnneYang720 AnneYang720 marked this pull request as ready for review August 30, 2022 14:05

@bwanglzu bwanglzu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, please always use single quote.

Comment thread docarray/array/storage/redis/find.py Outdated
Comment thread docarray/array/storage/redis/find.py Outdated
Comment thread docarray/array/storage/redis/find.py Outdated
Comment thread tests/unit/array/mixins/test_find.py Outdated

@bwanglzu bwanglzu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

Comment thread docarray/array/storage/redis/find.py Outdated
Comment thread docarray/array/storage/redis/find.py Outdated

@bwanglzu bwanglzu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoanFM JoanFM left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for merging PR where column types is set to Dict

Comment thread docs/advanced/document-store/redis.md Outdated
Comment thread docs/advanced/document-store/redis.md Outdated
Comment thread docs/advanced/document-store/redis.md Outdated

@alaeddine-13 alaeddine-13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done !

@JoanFM JoanFM merged commit cefb66c into docarray:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants