fix(array): fix add not performing deep copy#582
Merged
Conversation
Jackmin801
force-pushed
the
fix-docarray-545
branch
2 times, most recently
from
2b2cadd to
e68bd17
Compare
Jackmin801
changed the title
Contributor
Author
|
There is another occurrence of this code. Might want to fix that one too. |
Jackmin801
force-pushed
the
fix-docarray-545
branch
2 times, most recently
from
774f1d5 to
bd1167d
Compare
alaeddine-13
approved these changes
Oct 3, 2022
alaeddine-13
left a comment
alaeddine-13
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution, lgtm, will check if CI is passing
Codecov Report
@@ Coverage Diff @@
## main #582 +/- ##
===========================================
- Coverage 84.91% 40.25% -44.67%
===========================================
Files 133 133
Lines 6708 6708
===========================================
- Hits 5696 2700 -2996
- Misses 1012 4008 +2996
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
@Jackmin801 it looks like some tests are failing in tests/unit/document/test_plot.py, can you take a look ? |
Jackmin801
force-pushed
the
fix-docarray-545
branch
from
13d1efd to
d7f5005
Compare
Contributor
Author
|
Are the failed tests expected? Seems like some of them are about Jina login |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals: