Skip to content

chore: housekeeping#590

Merged
hanxiao merged 7 commits into
mainfrom
fix-better-error-msg
Oct 7, 2022
Merged

chore: housekeeping#590
hanxiao merged 7 commits into
mainfrom
fix-better-error-msg

Conversation

@hanxiao

@hanxiao hanxiao commented Oct 6, 2022

Copy link
Copy Markdown
Member

fix: better error message on bad selector
docs(dataclass): add uri type
docs: fix #580
feat(dataclass): add uri type

@codecov

codecov Bot commented Oct 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #590 (9ed6e40) into main (376e9fa) will decrease coverage by 0.01%.
The diff coverage is 42.10%.

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
- Coverage   84.92%   84.91%   -0.02%     
==========================================
  Files         133      133              
  Lines        6708     6714       +6     
==========================================
+ Hits         5697     5701       +4     
- Misses       1011     1013       +2     
Flag Coverage Δ
docarray 84.91% <42.10%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/array/mixins/find.py 88.65% <0.00%> (ø)
docarray/array/queryset/lookup.py 78.26% <0.00%> (ø)
docarray/array/queryset/parser.py 87.09% <0.00%> (ø)
docarray/array/storage/annlite/helper.py 50.00% <0.00%> (ø)
docarray/document/generators.py 86.32% <0.00%> (ø)
docarray/document/mixins/plot.py 78.91% <0.00%> (ø)
docarray/document/mixins/porting.py 93.15% <0.00%> (ø)
docarray/dataclasses/setter.py 92.15% <33.33%> (-3.68%) ⬇️
docarray/dataclasses/types.py 91.37% <50.00%> (ø)
docarray/document/mixins/multimodal.py 93.33% <50.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Han Xiao <han.xiao@jina.ai>
Signed-off-by: Han Xiao <han.xiao@jina.ai>
Comment thread docs/fundamentals/dataclass/construct.md Outdated
Co-authored-by: Joan Fontanals <joan.martinez@jina.ai>
Signed-off-by: Han Xiao <han.xiao@jina.ai>
@JoanFM

JoanFM commented Oct 6, 2022

Copy link
Copy Markdown
Member

Highlight also URI to ease the Release Notes

Signed-off-by: Han Xiao <han.xiao@jina.ai>
@hanxiao hanxiao changed the title fix: better error message on bad selector chore: housekeeping Oct 6, 2022
@JoanFM JoanFM linked an issue Oct 6, 2022 that may be closed by this pull request
@github-actions

github-actions Bot commented Oct 6, 2022

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-better-error-msg--jina-docs.netlify.app 🎉

@hanxiao hanxiao merged commit 168dda5 into main Oct 7, 2022
@hanxiao hanxiao deleted the fix-better-error-msg branch October 7, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: document stores disappeared in api reference

2 participants