feat: add config for pca in annlite#606
Merged
Merged
Conversation
JoanFM
requested changes
Oct 11, 2022
JoanFM
left a comment
JoanFM
left a comment
Member
There was a problem hiding this comment.
what about the annlite version? is it compatible?
alaeddine-13
left a comment
alaeddine-13
left a comment
Member
There was a problem hiding this comment.
can you make sure it's documented here ?
https://docarray.jina.ai/advanced/document-store/annlite/#config
also double check if we miss other params
Contributor
Author
|
No need to change the version, we already have this |
Codecov Report
@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 133 133
Lines 6714 6715 +1
=======================================
+ Hits 5701 5702 +1
Misses 1013 1013
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals: Enable loading indexer with PCA in DocumentArray AnnLite backend.
In AnnLite we load the model by their
params_hashwhich compute by hashingn_dim,n_components...So in order to successfully load the dumped indexer, we need to pass the
n_componentsto AnnLite.n_components, which is the output dimension of PCA, inannlite/backend.pyAnnliteConfig