fix(array): make docarrays sync when explicitly synced and when exiting context manager only#625
Merged
Conversation
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #625 +/- ##
==========================================
+ Coverage 85.01% 85.07% +0.06%
==========================================
Files 133 133
Lines 6745 6720 -25
==========================================
- Hits 5734 5717 -17
+ Misses 1011 1003 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
requested changes
Oct 17, 2022
Jackmin801
force-pushed
the
fix-array-529
branch
from
9a6add7 to
312169b
Compare
Jackmin801
commented
Oct 17, 2022
JoanFM
requested changes
Oct 17, 2022
JoanFM
left a comment
JoanFM
left a comment
Member
There was a problem hiding this comment.
Please, remember to clarify in Documentation
JoanFM
reviewed
Oct 18, 2022
JoanFM
left a comment
JoanFM
left a comment
Member
There was a problem hiding this comment.
Add Documentation about sync intergace
Contributor
Author
|
Maybe combine into tabs so its more consistent with other sections in the document? |
JoanFM
approved these changes
Oct 18, 2022
NicholasDunham
suggested changes
Oct 18, 2022
NicholasDunham
left a comment
NicholasDunham
left a comment
Contributor
There was a problem hiding this comment.
One minor change; otherwise looks good
Co-authored-by: Nicholas Dunham <11730795+NicholasDunham@users.noreply.github.com> Signed-off-by: Jackmin801 <56836461+Jackmin801@users.noreply.github.com>
JoanFM
approved these changes
Oct 18, 2022
|
📝 Docs are deployed on https://ft-fix-array-529--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
ModuleNotFoundErrorwhen using elasticsearch as storage backend #529